Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests in ESM mode #4392

Merged
merged 42 commits into from
Oct 24, 2024
Merged

Run tests in ESM mode #4392

merged 42 commits into from
Oct 24, 2024

Conversation

char0n
Copy link
Member

@char0n char0n commented Oct 22, 2024

We need to use pure EMS packages in while running tests. Because our tests were using @babel/register and technically were running in CommonJS mode, using pure ESM packages was out of question.


TODO:

  • remove @babel/register

Cannot remove @babel/register as it's still used by the tree-sitter-yaml build process.

@char0n char0n self-assigned this Oct 22, 2024
@char0n char0n added enhancement New feature or request tests tag for anything test related labels Oct 22, 2024
char0n added 24 commits October 22, 2024 13:36
@char0n char0n marked this pull request as ready for review October 24, 2024 18:24
@char0n char0n merged commit 2c0e646 into main Oct 24, 2024
8 checks passed
@char0n char0n deleted the char0n/esm-tests branch October 24, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests tag for anything test related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant