fix(ls): Fix regex in Swagger 2.0 basePath linting rule #3566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalemRoelofsSB
force-pushed
the
issue-3565
branch
from
b26f8fa to
e4cd7ae
Compare
|
It's interesting that prettier sees these as useless escapes https://github.com/swagger-api/apidom/actions/runs/7274733595/job/19821257422?pr=3566 |
char0n
reviewed
Dec 20, 2023
packages/apidom-ls/src/config/openapi/swagger/lint/base-path--pattern.ts
Outdated
Show resolved
Hide resolved
char0n
requested changes
Dec 20, 2023
There was a problem hiding this comment.
Hi @CalemRoelofsSB, suggested the change that actually works.
By doing single \s we're actually putting s character there again. We need to do double slashing to actually create a \s string: \\s.
|
@char0n ah perfect, sorry about that! I've added it in now. |
|
@CalemRoelofsSB please next time squash + merge your PR or let me do it. This PR created 3 commit messages in main branch and broke the linear history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #3565
This PR fixes the regex in the
OPENAPI2_SWAGGER_FIELD_BASE_PATH_PATTERNlinting rule so that it matches on whitespace characters instead of the letter 's'