This repository has been archived by the owner on Dec 9, 2021. It is now read-only.
Upgrade react navigation #226
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
se-bastiaan
reviewed
Nov 17, 2020
| import * as React from 'react'; | ||
| import { DrawerActions } from '@react-navigation/native'; | ||
|
|
||
| export const navigationRef = React.createRef(); |
There was a problem hiding this comment.
This should all be in the navigation saga
| import * as calendarActions from '../actions/calendar'; | ||
| import * as membersActions from '../actions/members'; | ||
| import * as welcomeActions from '../actions/welcome'; | ||
| import { settingsActions } from '../actions/settings'; | ||
| import NavigationService from '../navigation'; | ||
| import * as RootNavigation from '../ui/components/navigation/RootNavigation'; |
There was a problem hiding this comment.
This is a weird import
There was a problem hiding this comment.
because you are basically importing UI components into a saga.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #142
Summary
Updated react-navigation to version 5.
How to test
Steps to test the changes you made:
Check all screens and buttons in the navigators.