Skip to content

Commit

Permalink
Merge pull request accel-ppp#219 from svlobanov/alpine-ci-disable-cha…
Browse files Browse the repository at this point in the history
…p-secrets

tests,ci: disable chap-secrets related tests on alpine
  • Loading branch information
DmitriyEshenko authored Nov 28, 2024
2 parents bc81d83 + 3ffd332 commit cc83430
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ jobs:
timeout-minutes: 5
run: >
ssh -i ssh-key -p2222 alpine@localhost "cd accel-ppp/tests &&
doas python3 -m pytest -Wall --order-dependencies -v -m \"not ipoe_driver and not vlan_mon_driver\""
doas python3 -m pytest -Wall --order-dependencies -v -m \"not ipoe_driver and not vlan_mon_driver and not chap_secrets\""
- name: Display processes and dmesg after tests
if: ${{ always() }}
run: >
Expand All @@ -288,7 +288,7 @@ jobs:
if: ${{ always() }}
run: >
ssh -i ssh-key -p2222 alpine@localhost "cd accel-ppp/tests &&
doas python3 -m pytest -Wall --order-dependencies -v -m \"not vlan_mon_driver\""
doas python3 -m pytest -Wall --order-dependencies -v -m \"not vlan_mon_driver and not chap_secrets\""
- name: Display processes and dmesg after tests
if: ${{ always() }}
run: >
Expand All @@ -305,7 +305,7 @@ jobs:
timeout-minutes: 5
run: >
ssh -i ssh-key -p2222 alpine@localhost "cd accel-ppp/tests &&
doas python3 -m pytest -Wall --order-dependencies -v"
doas python3 -m pytest -Wall --order-dependencies -v -m \"not chap_secrets\""
- name: Display processes and dmesg after tests
if: ${{ always() }}
run: >
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@ def accel_pppd_config(veth_pair_netns, chap_secrets_config_file):
# test dhcpv4 shared session without auth check
@pytest.mark.dependency(depends=["ipoe_driver_loaded"], scope="session")
@pytest.mark.ipoe_driver
@pytest.mark.chap_secrets
def test_ipoe_shared_session_chap_secrets(
dhclient_instance, accel_cmd, veth_pair_netns
):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ def accel_pppd_config(veth_pair_netns, chap_secrets_config_file, lua_script_file
# test dhcpv4 shared session without auth check
@pytest.mark.dependency(depends=["ipoe_driver_loaded"], scope="session")
@pytest.mark.ipoe_driver
@pytest.mark.chap_secrets
def test_ipoe_shared_session_lua_chap_secrets(
dhclient_instance, accel_cmd, veth_pair_netns
):
Expand Down
1 change: 1 addition & 0 deletions tests/accel-pppd/pppoe/test_pppoe_session_chap_secrets.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ def pppd_config(veth_pair_netns):


# test pppoe session without auth check
@pytest.mark.chap_secrets
def test_pppoe_session_chap_secrets(pppd_instance, accel_cmd):

# test that pppd (with accel-pppd) started successfully
Expand Down
4 changes: 4 additions & 0 deletions tests/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ def pytest_configure(config):
"markers",
"vlan_mon_driver: marks tests as related to ipoe kernel module (deselect with '-m \"not vlan_mon_driver\"')",
)
config.addinivalue_line(
"markers",
"chap_secrets: marks tests as related to chap-secrets module (deselect with '-m \"not chap_secrets\"')",
)


# accel-pppd executable file name
Expand Down

0 comments on commit cc83430

Please sign in to comment.