-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt omniqueue as a queue backend and remove our own in-memory queue implementation #1188
Conversation
caea783
to
74e3d76
Compare
LGTM, but somebody who was a bit more invested in the development of omniqueue than me should probably chime in. |
74e3d76
to
dd732ce
Compare
For now the state machine is only used for the implementation of run_with_retries, but it will be used directly in the next commit, to get around limitations of run_with_retries.
dd732ce
to
567657e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
567657e
to
2afa485
Compare
2afa485
to
39e16bb
Compare
@svix-jplatte did this get solved somehow? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes, there was one place where |
Correct. It's more of a stub than anything else. Like a dummy (no-op) cache implementation. |
Depends on #1185 (merged), svix/omniqueue-rs#24.I have deleted low-level tests for the in-memory queue since its basic functionality should be tested inside omniqueue, not here. Do we have tests for higher-level functionality that uses the in-memory queue backend in some scenarios?
The redis and SQS implementation should probably be replaced by the implementations found in Omniqueue in a follow-up PR, to keep this one reasonably small.