refactor(memory): use mpsc not broadcast #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svix-onelson
force-pushed
the
onelson/mpsc-not-broadcast
branch
from
a9d2b9a to
a6934a0
Compare
Unsure if this is going to be needed. Can avoid redoing/adding mem backend by simply giving usize::MAX for capacity, or whatever is allowable for broadcast. The underlying channel is a private detail.
svix-onelson
force-pushed
the
onelson/mpsc-not-broadcast
branch
from
a6934a0 to
e0ed48c
Compare
svix-jplatte
approved these changes
Feb 2, 2024
| .rx | ||
| .recv() | ||
| .await | ||
| .ok_or_else(|| QueueError::Generic("recv failed".into()))?; |
There was a problem hiding this comment.
I used QueueError::Generic(mpsc::TryRecvError::Disconnected) here instead in my local branch, not sure if it's better or worse than what you wrote though ^^
There was a problem hiding this comment.
Feel free to fix that up as you see fit in your continuing dev ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially motivated by the fact broadcast has consumer semantics that don't align with the higher level API we'd like to expose, but I hear there's also a perf concern.