Redis: Refactor delayed-message enqueuing #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make this less ambiguous by requiring `InternalPayload`s to be passed to the functions that add messages back to the main queue instead of `&[u8]`.
jaymell
force-pushed
the
redis-refactor
branch
from
63999f5 to
5f8584c
Compare
svix-gabriel
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the code here a bit more generic and less ambiguous by requiring
InternalPayloadinstead of&[u8]to be passed to the functionsthat move messages from delayed queue to the main queue. This will
enable reusing these functions later for things like redriving DLQs.