margins: now in user units, and working for all aspect ratios cases #86
Conversation
|
Not sure how you test this, I used https://codepen.io/jonenst/pen/mdrgwoJ and copypaste to a local file and imported the build like The code can probably become shorter by using more symmetries between meet and slice, but I wasn't sure it was worth it, I understand this one better. |
src/svg.panzoom.js
Outdated
| preserveAspectRatio.align === preserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMINYMIN || | ||
| preserveAspectRatio.align === preserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMIN || | ||
| preserveAspectRatio.align === preserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMIN) { | ||
| viewportLeftOffset = -widthOffset |
There was a problem hiding this comment.
Just looking at all the symmetry going on, this should be positive...
There was a problem hiding this comment.
Actually I think this should be viewportRightOffset and the other one viewportLeftOffset
src/svg.panzoom.js
Outdated
| preserveAspectRatio.align === preserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMINYMAX || | ||
| preserveAspectRatio.align === preserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMIDYMAX || | ||
| preserveAspectRatio.align === preserveAspectRatio.SVG_PRESERVEASPECTRATIO_XMAXYMAX) { | ||
| viewportRightOffset = widthOffset |
There was a problem hiding this comment.
...while this should be negative.
|
oh no I hope the whole symmetry is not different now :D. I shorted the code by a lot using symmetry. we'll see ^^ |
|
Yeah the slice mode was broken, the testing XMid/Min/Max and YMid/MinMax were swapped, and there was the bug you noticed, assigning to the wrong variable |
see #80