Disable inline styles by default if CSS at rules are present. #2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inlineStyles plugin will move styles inline even if they are used in media queries, which causes the media queries to not work.
This PR changes the default behavior of the plugin so that it will not inline any styles if there are at-rules present in the CSS.
There is logic in the plugin to skip over some media queries. I can't think of a use case for this, but there are 2 test cases that rely on it, so I preserved this behavior. Since the default is now to not inline the styles if at-rules are present, I added a new configuration parameter ("disableIfAtRulesPresent"), and changed these 2 test cases to override the default setting of this parameter.
Resolves #1834, resolves #1726, resolves #1359.