Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed V3.3.0 Common JS missing loadConfig and optimize exports #1984

Merged
merged 8 commits into from
May 8, 2024

Conversation

nuintun
Copy link
Contributor

@nuintun nuintun commented May 8, 2024

esm

import { loadConfig, optimize } from 'svgo';

cjs

const { loadConfig, optimize } = require('svgo');

browser

import { optimize } from 'svgo/browser';

@nuintun nuintun changed the title fix: fixed Common JS missing loadConfig and optimize exports Fixed Common JS missing loadConfig and optimize exports May 8, 2024
@nuintun nuintun changed the title Fixed Common JS missing loadConfig and optimize exports Fixed V3.3.0 Common JS missing loadConfig and optimize exports May 8, 2024
Copy link
Member

@SethFalco SethFalco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating this as soon as you spotted the issue, and sorry for letting that through!

I'll be sure to check if there's any other public interfaces that we need to cover with tests too.

I've added a commit to your PR to at least add one test case, just to verify that loadConfig is defined. Once CI passes, happy to merge and I'll make a release. 👍🏽

@SethFalco SethFalco merged commit 3964d64 into svg:main May 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants