fix: add explicit ascent override on nimbus sans typeface #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Font Face Alignment
On Chromium browsers, Nimbus Sans was not vertically aligned properly. This appears to be a due to a difference in how Firefox and Chromium handles fonts with different ascents/descent.
Here is how Chromium/Linux looked when Nimbus Sans was available:
I was able to resolve this by setting an explicit
ascent-override
, however I later found that the theme Docusaurus ships by default already uses a reasonable local font stack. I opted to remove our font stack altogether and use the predefined--ifm-font-family-*
, which also resolves the issue.Here is how it looks now on Chromium/Linux:
Accessibility
In some areas of the site, I forget to also style on
:focus
as well as:hover
for uses that navigate the web with tab or other assistive technologies.Redundant Classes
Just removes the
buttons
class which was no longer in use.