Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate to makefile and add deduplicate task #2

Merged
merged 1 commit into from
May 25, 2024
Merged

Conversation

SethFalco
Copy link
Member

@SethFalco SethFalco commented May 25, 2024

Deduplicate Files

Adds a build step to delete duplicate files, a test suite doesn't need these.

Quality of Life

  • Migrates the script over to a Makefile for easier maintenance.
  • Splits the script over multiple commands, so each can be run independently.
  • Adds --no-clobber to wget commands to avoid redownloading the archives if we already have them locally. (Doesn't impact CI, run make clean if you specifically want to fetch archives again.)
  • Adds CI task on PR to try and build the archive, so we can see if it builds succesfully on GitHub before merging.

Related

@SethFalco SethFalco merged commit 32ed67e into main May 25, 2024
1 check passed
@SethFalco SethFalco deleted the deduplicate branch May 25, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant