Support Keycloak Organization Feature (PREVIEW) #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sventorben
force-pushed
the
orgs_support
branch
from
e10811a to
c704ee5
Compare
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
Comment on lines
+51
to
+52
| if (EMAIL_ATTRIBUTE.equalsIgnoreCase(config.userAttribute()) && !user.isEmailVerified() | ||
| && !config.forwardUserWithUnverifiedEmail()) { |
There was a problem hiding this comment.
❌ New issue: Complex Conditional
discoverForUser has 1 complex conditionals with 2 branches, threshold = 2
Comment on lines
+51
to
+57
| if (EMAIL_ATTRIBUTE.equalsIgnoreCase(config.userAttribute()) && !user.isEmailVerified() | ||
| && !config.forwardUserWithUnverifiedEmail()) { | ||
| LOG.warnf("Email address of user '%s' is not verified and forwarding not enabled", user.getId()); | ||
| emailDomain = Optional.empty(); | ||
| } else { | ||
| emailDomain = domainExtractor.extractFrom(user); | ||
| } |
There was a problem hiding this comment.
❌ New issue: Bumpy Road Ahead
discoverForUser has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function
src/main/java/de/sventorben/keycloak/authentication/hidpd/discovery/email/DomainExtractor.java
Show resolved
Hide resolved
sventorben
changed the title
This is just a rough draft - needs testing and refactorings. Signed-off-by: Sven-Torben Janus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a rough draft - needs refactorings, testing, and documentation.
CONSIDER THIS TO BE A PREVIEW FEATURE WHICH MAY BE REMOVED WITHOUT WARNING!
Relates to #340