Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (experimental) partial support for Svelte v5 parser #421

Merged
merged 7 commits into from
Nov 14, 2023

Conversation

ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented Nov 14, 2023

related to sveltejs/eslint-plugin-svelte#587, #423

This PR is still a work in progress. It must support at least the following:

Copy link

changeset-bot bot commented Nov 14, 2023

🦋 Changeset detected

Latest commit: 8713722

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-eslint-parser Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coveralls
Copy link

coveralls commented Nov 14, 2023

Pull Request Test Coverage Report for Build 6863695899

  • 34 of 34 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 90.973%

Totals Coverage Status
Change from base Build 6862417747: 0.06%
Covered Lines: 2236
Relevant Lines: 2374

💛 - Coveralls

tsconfig.json Outdated Show resolved Hide resolved
Copy link
Member

@baseballyama baseballyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's LGTM. Thank you!
But how we will release it?
We will go to same way as prettier-plugin-svelte?
(Just release minor version.)

https://github.com/sveltejs/prettier-plugin-svelte/releases/tag/v3.1.0

@ota-meshi ota-meshi mentioned this pull request Nov 14, 2023
18 tasks
@ota-meshi
Copy link
Member Author

I'd like to release it at v0.34 if it doesn't contain breaking changes, but since it's still v0, minor releases may also require people to explicitly use the new version.
After ESLint v9 is released, I would like to release a major version of this parser and eslint-plguin-svelte.

@ota-meshi ota-meshi changed the title feat: add experimental support for Svelte v5 feat: (experimental) partial support for Svelte v5 parser Nov 14, 2023
@ota-meshi ota-meshi marked this pull request as ready for review November 14, 2023 12:39
@ota-meshi ota-meshi merged commit 59fc0e9 into main Nov 14, 2023
13 checks passed
@ota-meshi ota-meshi deleted the test-svelte-v5 branch November 14, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants