Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repl): Rollup v4 #546

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

chore(repl): Rollup v4 #546

wants to merge 3 commits into from

Conversation

PuruVJ
Copy link
Collaborator

@PuruVJ PuruVJ commented Dec 2, 2023

Bumps Rollup/browser to v4, which uses WebAssembly.

Comparing, new version seems to load 400KB gzip more overall, which are added from the new Rollup WASM(1.6Mb on its own)

Decision on whether to update to v4 or stay on v3 for the foreseeable future is pending

Copy link

vercel bot commented Dec 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hn ✅ Ready (Inspect) Visit Preview Dec 3, 2023 10:36am
repl ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 3, 2023 10:36am

@PuruVJ PuruVJ marked this pull request as ready for review December 2, 2023 20:28
@benmccann
Copy link
Member

Yeah, I don't know how I feel about the increased size. I might hold off for the time being

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants