Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] add share button in REPL #182

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

johannchopin
Copy link

Fixes #95.

The button svg was created by using figma https://www.figma.com/file/9F50hFRCB9jdKgSvAdGNG7/svelte-edit-repl-btn?node-id=0%3A1. If a modification is needed just tell me I will add you as a collaborator.

Sep-03-2021 19-24-58

@vercel
Copy link

vercel bot commented Dec 16, 2021

@johannchopin is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@johannchopin
Copy link
Author

@benmccann Do you have suggestion to clarify the term embed over share?

@vercel
Copy link

vercel bot commented Dec 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/svelte/svelte-dev/8thgEWmVrMfhbTz2uRfsXMn7drg1
✅ Preview: https://svelte-dev-git-fork-johannchopin-feature-add-shar-e067aa-svelte.vercel.app

@benmccann
Copy link
Member

Here's the original PR for reference for the other reviewers: sveltejs/svelte#6703

@Rich-Harris
Copy link
Member

Thank you! I'm not sure it makes sense to add this to the UI until (/unless) we have a mechanism for creating embeds. We'd need to have a thorough conversation about whether that's something we want to do, and what it would involve exactly. In the meantime I think links are the appropriate way to share REPLs

@benmccann benmccann added the REPL label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[site] Add a share button in the REPL page controls
3 participants