Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleting code duplication, re-arranging head elements and quick fixes #641

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Deleting code duplication, re-arranging head elements and quick fixes #641

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40bcf35
Deleting unnecessary twitter meta elements to reduce code duplication…
cevdetardaharan Jul 22, 2024
535ab58
Update app.html (changing doctype)
cevdetardaharan Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions content/tutorial/common/src/app.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8" />
<link rel="icon" href="%sveltekit.assets%/favicon.png" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="color-scheme" content="dark light" />
<meta charset="utf-8">
<meta name="viewport" content="width=device-width">
<link rel="icon" href="%sveltekit.assets%/favicon.png">
<meta name="color-scheme" content="dark light">
%sveltekit.head%

<style>
Expand Down
18 changes: 9 additions & 9 deletions src/app.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
<!DOCTYPE html>
<!doctype html>
<html lang="en">
<head>
<meta charset="utf-8" />
<link rel="icon" href="%sveltekit.assets%/favicon.png" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="color-scheme" content="dark light" />
<meta name="theme-color" media="(prefers-color-scheme: light)" content="#fff" />
<meta name="theme-color" media="(prefers-color-scheme: dark)" content="#2e2e2e" />
<meta charset="utf-8">
<meta name="viewport" content="width=device-width">
<link rel="icon" href="%sveltekit.assets%/favicon.png">
<meta name="color-scheme" content="dark light">
<meta name="theme-color" media="(prefers-color-scheme: light)" content="#fff">
<meta name="theme-color" media="(prefers-color-scheme: dark)" content="#2e2e2e">
<meta
name="description"
content="Learn Svelte and SvelteKit with an interactive browser-based tutorial"
/>
<link rel="manifest" href="/manifest.json" />
>
<link rel="manifest" href="/manifest.json">
%sveltekit.head%
</head>
<body data-sveltekit-preload-data="hover">
Expand Down
20 changes: 8 additions & 12 deletions src/routes/tutorial/[slug]/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,18 +143,14 @@
<svelte:head>
<title>{data.exercise.chapter.title} / {data.exercise.title} • Svelte Tutorial</title>

<meta name="twitter:title" content="{data.exercise.title} • Svelte Tutorial" />
<meta name="twitter:card" content="summary" />
<meta name="twitter:site" content="@sveltejs" />
<meta name="twitter:creator" content="@sveltejs" />
<meta name="twitter:image" content="https://svelte.dev/images/twitter-thumbnail.jpg" />
<meta property="twitter:domain" content="learn.svelte.dev" />
<meta property="twitter:url" content="https://learn.svelte.dev" />

<meta property="og:title" content="{data.exercise.title} • Svelte Tutorial" />
<meta property="og:url" content="https://learn.svelte.dev" />
<meta property="og:type" content="website" />
<meta property="og:image" content="https://svelte.dev/images/twitter-thumbnail.jpg" />
<meta name="twitter:card" content="summary">
<meta name="twitter:site" content="@sveltejs">
<meta name="twitter:creator" content="@sveltejs">
<meta property="twitter:domain" content="learn.svelte.dev">
<meta property="og:url" content="https://learn.svelte.dev">
<meta property="og:type" content="website">
<meta property="og:title" content="{data.exercise.title} • Svelte Tutorial">
<meta property="og:image" content="https://svelte.dev/images/twitter-thumbnail.jpg">
</svelte:head>

<svelte:window
Expand Down