Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow typescript configuration files #4105

Closed
wants to merge 4 commits into from

Conversation

ecstrema
Copy link
Contributor

This PR adds the possibility to use typescript configuration files, and makes use of this in the docs website.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Feb 24, 2022

🦋 Changeset detected

Latest commit: 537c2a7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/kit Patch
kit.svelte.dev Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bluwy
Copy link
Member

bluwy commented Feb 24, 2022

We just had a similar PR #4031 a while ago and got closed because we want to resort to sveltejs/rfcs#59 moving forward. Further reasons are noted at #4031 (comment), so unfortunately this won't likely be merged.

@ecstrema
Copy link
Contributor Author

ahh too bad.

@ecstrema ecstrema closed this Feb 24, 2022
@ecstrema ecstrema reopened this Feb 24, 2022
@ecstrema
Copy link
Contributor Author

I am reopening, because this PR introduces none of the problems in the discussion you linked above.

Except for using an external package. However, it works perfectly.

@bluwy
Copy link
Member

bluwy commented Feb 24, 2022

It introduces compatibility issues with language tools and vite-plugin-svelte no? They can't load svelte config in typescript.

@ecstrema
Copy link
Contributor Author

ecstrema commented Feb 24, 2022

Not that I can see...

EDIT: actually yes, it does, see my next comment

@ecstrema
Copy link
Contributor Author

so vite plugins and aliases are not found.

@ecstrema ecstrema closed this Feb 24, 2022
@ecstrema
Copy link
Contributor Author

I guess I just didn't look close enough.

@ecstrema
Copy link
Contributor Author

Still I believe that updating accordingly the language tools shouldn't be that much of a deal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants