Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for svelte.config.ts #12457

Closed
wants to merge 6 commits into from
Closed

Conversation

fzn0x
Copy link

@fzn0x fzn0x commented Jul 10, 2024

This added support for svelte.config.ts with minimal changes and independent. This does not provide types support, however, now we could run svelte.config.ts out-of-the-box.

Screenshot 2024-07-10 092107

Closes #2576

Note that, svelte.config.js is prioritized by default.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link

changeset-bot bot commented Jul 10, 2024

🦋 Changeset detected

Latest commit: c5ed56c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fzn0x
Copy link
Author

fzn0x commented Jul 10, 2024

Not sure about the others workflow error like playwright can't read or vercel.

@fzn0x
Copy link
Author

fzn0x commented Jul 10, 2024

Looks like it's a flaky tests

@@ -2,6 +2,8 @@ import fs from 'node:fs';
import path from 'node:path';
import * as url from 'node:url';
import options from './options.js';
import pkg from 'typescript';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would create a direct dependency from sveltekit to typescript, forcing everyone, even non-typescript users to install it. That's a big no.

@dummdidumm
Copy link
Member

Thanks, but I'm pretty sure this is insufficient. It only transpiles the config file, but as soon as that one imports other TS files you'll get errors.
To support this we would have to bundle/transpile the config on the fly, similar to what Vite does.

@dominikg
Copy link
Member

There has not been a consensus that support for svelte.config.ts is going to happen. If it was, it would have to be added at a different level (see discussion in the linked issue) as all tools in the svelte ecosystem would have to be able to read it

@fzn0x
Copy link
Author

fzn0x commented Jul 10, 2024

I will think about other solutions later.

@fzn0x fzn0x closed this Jul 10, 2024
@fzn0x fzn0x deleted the main branch July 10, 2024 08:57
@fzn0x
Copy link
Author

fzn0x commented Jul 10, 2024

Question added in RFC sveltejs/rfcs#59 @dominikg @dummdidumm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add typescript version of svelte.config.js
3 participants