Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tailwindcss import insertions and execution order #221

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

AdrianGonz97
Copy link
Member

@AdrianGonz97 AdrianGonz97 commented Oct 25, 2024

closes #220

This is a good instance where having runsAfter would've been useful. While tailwindcss doesn't require prettier to function, ensuring that it's executed after prettier would've guaranteed that the prettier-plugin-tailwindcss is installed when they've both been selected

rather than bringing runsAfter back, I've tweaked the sorting order so that 2 adders that don't have dependsOn specified stay in place, which is just a temp fix

Re: Duplicate @import statements - this was another case where " vs ' made a difference

Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: be3a1cd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 25, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/sveltejs/cli/sv@221

commit: be3a1cd

@manuel3108 manuel3108 merged commit ce6b878 into main Oct 25, 2024
5 checks passed
@manuel3108 manuel3108 deleted the fix/tailwind-imports branch October 25, 2024 12:58
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npx sv create does not add prettier-plugin-tailwindcss to package.json and .prettierrc
2 participants