add option to export to cub5 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Talking with @connoramoreno, it will likely be best to separate the cubit model building functionality from |
connoramoreno
requested changes
Jun 3, 2024
parastell/parastell.py
Outdated
| ) | ||
| cub5_export = all_data['cub5_export'] | ||
| if cub5_export['export_cub5']: |
There was a problem hiding this comment.
Why do we need a export_cub5 flag if we're including a separate cub5_export dictionary in the YAML file?
There was a problem hiding this comment.
I'm intending this to be optional behavior, but since there are no other args to get passed having the dict doesn't really make sense, I'll change it to just be a single element
Co-authored-by: connoramoreno <[email protected]>
Co-authored-by: connoramoreno <[email protected]>
Co-authored-by: connoramoreno <[email protected]>
Co-authored-by: connoramoreno <[email protected]>
Co-authored-by: connoramoreno <[email protected]>
gonuke
reviewed
Jun 3, 2024
| ): | ||
| """Exports DAGMC neutronics H5M file of ParaStell components via | ||
| Coreform Cubit. | ||
| def build_cubit_model(self, skip_imprint=False, legacy_faceting=True): |
gonuke
approved these changes
Jun 3, 2024
connoramoreno
added a commit
that referenced
this pull request
Sep 10, 2024
add option to export to cub5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #111, trying again but from a branch on the upstream to hopefully pass CI
closes #93