Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept 'null' for duk_set_prototype() #1133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Accept 'null' for duk_set_prototype() #1133

wants to merge 2 commits into from

Conversation

svaarala
Copy link
Owner

@svaarala svaarala commented Dec 2, 2016 •
edited
Loading

Accept also null type for duk_set_prototype() to better align with Object.create().

  • Code change
  • Testcases
  • API documentation
  • Releases entry

@svaarala svaarala added the api label Dec 2, 2016
@svaarala svaarala added this to the v2.0.0 milestone Dec 2, 2016
@svaarala
Copy link
Owner Author

svaarala commented Dec 2, 2016

Related, duk_get_prototype() now returns an object or undefined to match the duk_set_prototype() behavior. That should also be changed to "null".

If that's done, this change is no longer a compatible change (for success path code anyway) so maybe duk_set_prototype() should no longer accept undefined either.

@svaarala svaarala force-pushed the api-set-prototype-accept-null branch from 5a84325 to df0878c Compare December 2, 2016 12:01
@svaarala svaarala modified the milestones: v3.0.0, v2.0.0 Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@svaarala