Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed SKZoomingScrollView Initialization #427

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on May 19, 2022

  1. Fixed SKZoomingScrollView Initialization

    * When `SKZoomingScrollView` is initialized, the `setup()` method is called twice: once in `init(frame:)` and then once more in `init(frame:browser:)`
    * Double call of `setup()` results in UI elements (such as `SKDetectingImageView`) created twice
    * Even though `SKZoomingScrollView`’s properties (e.g. `imageView`) are reassigned on the second call of `setup()`, the UI elements remain in the view hierarchy and device’s memory
    * To fix this, `init(frame:browser:)` has been to changed to be a designated initializer, and `init(frame:)` has been removed
    yakovmanshin committed May 19, 2022
    Configuration menu
    Copy the full SHA
    e68076b View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Configuration menu
    Copy the full SHA
    56b5fb2 View commit details
    Browse the repository at this point in the history