Fix infinite loop in vue2

surveyjs · Oct 7, 2024 · f4ad70a · f4ad70a
1 parent 841f497
commit f4ad70a
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 12 deletions.
diff --git a/src/vue/base.ts b/src/vue/base.ts
@@ -19,8 +19,10 @@ export class BaseVue extends Vue {
  }
  protected onMounted() { }
  protected onUpdated() { }
+ protected onBeforeUpdated() {}
  protected onDestroyed() { }
- protected onCreated() {
+ protected onCreated() {}
+ created() {
  var model = this.getModel();
  if (!model) return;
  model.iteratePropertiesHash((propertiesHash: any, name: any) => {
@@ -41,15 +43,14 @@ export class BaseVue extends Vue {
  Vue.set(propertiesHash, name, val);
  else propertiesHash[name] = val;
  };
- }
- created() {
  this.onCreated();
  }
  beforeMount() {
  this.setIsRendering(true);
  }
  beforeUpdate() {
  this.setIsRendering(true);
+ this.onBeforeUpdated();
  }
  mounted() {
  this.setIsRendering(false);

diff --git a/src/vue/components/dropdown/dropdown.vue b/src/vue/components/dropdown/dropdown.vue
@@ -130,14 +130,8 @@ export class DropdownComponent extends BaseVue {
  inputChange(event: any) {
  this.model.inputStringRendered = event.target.value;
  }
-
- public get showSelectedItemLocText() {
- return this.question.showSelectedItemLocText;
- }
-
- public get selectedItemLocText() {
- return this.question.selectedItemLocText;
- }
+ showSelectedItemLocText: any = null;
+ selectedItemLocText: any = false;
 
  public click(event: any) {
  this.model?.onClick(event);
@@ -175,8 +169,17 @@ export class DropdownComponent extends BaseVue {
  }
  }
  }
+ private updateSelectedItemProperties() {
+ this.showSelectedItemLocText = this.question.showSelectedItemLocText;
+ this.selectedItemLocText = this.question.selectedItemLocText;
+ }
+ onCreated(): void {
+ this.updateSelectedItemProperties();
+ }
+ onBeforeUpdated(): void {
+ this.updateSelectedItemProperties();
+ }
 }
-
 Vue.component("sv-dropdown", DropdownComponent);
 export default DropdownComponent;
 </script>