Fix showing description on empty survey in designer

surveyjs · Sep 11, 2023 · aca20d8 · aca20d8
1 parent 6972949
commit aca20d8
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/src/panel.ts b/src/panel.ts
@@ -322,9 +322,9 @@ export class PanelModelBase extends SurveyElement<Question>
   protected canShowTitle(): boolean { return true; }
   @property({ defaultValue: true }) showDescription: boolean;
   get _showDescription(): boolean {
-    return this.survey && (<any>this.survey).showPageTitles && this.hasDescription && !this.isDesignMode ||
-      (this.showDescription && this.isDesignMode && this.showTitle &&
-        settings.designMode.showEmptyTitles &&
+    if(!this.hasTitle && this.isDesignMode) return false;
+    return this.survey && (<any>this.survey).showPageTitles && this.hasDescription ||
+      (this.showDescription && this.isDesignMode &&
         settings.designMode.showEmptyDescriptions);
   }
   public localeChanged() {

diff --git a/src/survey-element.ts b/src/survey-element.ts
@@ -70,7 +70,7 @@ export abstract class SurveyElementCore extends Base implements ILocalizableOwne
       const property: JsonObjectProperty = Serializer.findProperty(this.getType(), "description");
       showPlaceholder = !!(property?.placeholder);
     }
-    this.hasDescription = !!newDescription || showPlaceholder;
+    this.hasDescription = !!newDescription || (showPlaceholder && this.isDesignMode);
   }
 
   get locDescription(): LocalizableString {

diff --git a/tests/paneltests.ts b/tests/paneltests.ts
@@ -783,6 +783,10 @@ QUnit.test(
       page._showDescription,
       "Entered description is visible in DesignMode"
     );
+    page.title = "";
+    page.description = "";
+    assert.notOk(page.hasTitle, "No title");
+    assert.notOk(page._showDescription, "No description");
   }
 );