Logic Tab autosaves incorrect "setValue" after loading page fix #5083 #5091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
novikov82
reviewed
Jan 22, 2024
| @@ -105,6 +105,8 @@ export class SurveyLogicType { | |||
| if ((<any>obj).setOwner) { | |||
| (<any>obj).setOwner(this.survey); | |||
| } | |||
| //Do not fire notification about changes to our creator.survey model | |||
| obj["isGhost"] = true; | |||
There was a problem hiding this comment.
is it secure for our code?
There was a problem hiding this comment.
Yes, we have isGhost property from ItemValue and Triggers.
We can move it to Base class. I am not sure we need it.
Thank you,
Andrew
There was a problem hiding this comment.
It looks like hack. I am affraid that somebody can add isGhost for any other object type in future... If we want to keep isGhost only in ItemValue and Trigger maybe it could be better if we add condition for this setting, something like...?
if(obj instance of ItemValue || obj instanceof Trigger) {
obj["isGhost"] = true;
}
It still will be the hack, but more secure...
novikov82
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.