Finish updating the CreatorBase API (#5101)

* Finish updating the `CreatorBase` API * Delete `onConditionGetTitle` description
surveyjs · Jan 22, 2024 · 9b6f7e4 · 9b6f7e4
1 parent 3c41b9a
commit 9b6f7e4
Show file tree

Hide file tree

Showing 7 changed files with 212 additions and 132 deletions.
diff --git a/docs/sidebar.json b/docs/sidebar.json
@@ -86,8 +86,8 @@
       "Title": "Survey Creator API",
       "Items": [
         {
-          "Name": "surveycreator",
-          "Title": "SurveyCreator"
+          "Name": "surveycreatormodel",
+          "Title": "SurveyCreatorModel"
         },
         {
           "Name": "ICreatorOptions",

diff --git a/docs/uri.json b/docs/uri.json
@@ -20,6 +20,7 @@
   },
   "classRename": {
     "surveyeditor": "survey-creator",
-    "surveycreator": "survey-creator"
+    "surveycreator": "survey-creator",
+    "surveycreatormodel": "survey-creator"
   }
 }
diff --git a/packages/survey-creator-core/src/components/tabs/theme-builder.ts b/packages/survey-creator-core/src/components/tabs/theme-builder.ts
@@ -771,7 +771,7 @@ export class ThemeBuilder extends Base {
   }
   private patchFileEditors(survey: SurveyModel) {
     const questionsToPatch = survey.getAllQuestions(false, false, true).filter(q => q.getType() == "fileedit");
-    questionsToPatch.forEach(q => { (<QuestionFileEditorModel>q).onChooseFilesCallback = (input, onFilesChosen) => this.surveyProvider.chooseFiles(input, onFilesChosen); });
+    questionsToPatch.forEach(q => { (<QuestionFileEditorModel>q).onChooseFilesCallback = (input, callback) => this.surveyProvider.chooseFiles(input, callback); });
   }
 
   private getCoverJson(headerSettings: any): any {

diff --git a/packages/survey-creator-core/src/creator-base.ts b/packages/survey-creator-core/src/creator-base.ts
diff --git a/packages/survey-creator-core/src/creator-settings.ts b/packages/survey-creator-core/src/creator-settings.ts
@@ -306,13 +306,13 @@ export interface ISurveyCreatorOptions {
   uploadFiles(
     files: File[],
     question: Question,
-    uploadingCallback: (status: string, data: any) => any
+    callback: (status: string, data: any) => any
   ): void;
   getHasMachineTranslation(): boolean;
   doMachineTranslation(fromLocale: string, toLocale: string, strings: Array<string>, callback: (translated: Array<string>) => void): void;
   chooseFiles(
     input: HTMLInputElement,
-    onFilesChosen: (files: File[]) => void,
+    callback: (files: File[]) => void,
     context?: { element: SurveyElement, item?: ItemValue }
   ): void;
 }
@@ -458,11 +458,11 @@ export class EmptySurveyCreatorOptions implements ISurveyCreatorOptions {
   uploadFiles(
     files: File[],
     question: Question,
-    uploadingCallback: (status: string, data: any) => any
+    callback: (status: string, data: any) => any
   ): void { }
   getHasMachineTranslation(): boolean { return this.machineTranslationValue; }
   doMachineTranslation(fromLocale: string, toLocale: string, strings: Array<string>, callback: (translated: Array<string>) => void): void { }
-  chooseFiles(input: HTMLInputElement, onFilesChosen: (files: File[]) => void, context?: { element: SurveyElement, item?: ItemValue }): void { }
+  chooseFiles(input: HTMLInputElement, callback: (files: File[]) => void, context?: { element: SurveyElement, item?: ItemValue }): void { }
 }
 
 StylesManager.applyTheme("defaultV2");
diff --git a/packages/survey-creator-core/src/custom-questions/question-file.ts b/packages/survey-creator-core/src/custom-questions/question-file.ts
@@ -110,7 +110,7 @@ export class QuestionFileEditorModel extends QuestionFileModel {
       return true;
     }
   }
-  public onChooseFilesCallback: (input: HTMLInputElement, onFilesChosen: (files: File[]) => void) => void;
+  public onChooseFilesCallback: (input: HTMLInputElement, callback: (files: File[]) => void) => void;
   chooseFiles(event: Event) {
     if(this.isInputReadOnly || !this.onChooseFilesCallback) {
       return true;

diff --git a/packages/survey-creator-core/src/property-grid/index.ts b/packages/survey-creator-core/src/property-grid/index.ts
@@ -1431,8 +1431,8 @@ export class PropertyGridLinkEditor extends PropertyGridEditor {
     } else {
       question.acceptedTypes = getAcceptedTypesByContentMode("image");
     }
-    question.onChooseFilesCallback = ((input, onFilesChosen) => {
-      options.chooseFiles(input, onFilesChosen);
+    question.onChooseFilesCallback = ((input, callback) => {
+      options.chooseFiles(input, callback);
     });
   }