Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Surreal.set call Surreal.let #96

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Wouterkoorn
Copy link

@Wouterkoorn Wouterkoorn commented Apr 1, 2024

What is the motivation?

Reducing code duplication. Removes risk of forgetting to change set when changing let

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

What does this change do?

The Surreal.set function is documented with """Alias for `let`""". This PR changes the contents of the set function to call let, instead of containing let's copy-pasta code.

What is your testing strategy?

No functionality has changed.

mypy OK
pre-commit OK
./scripts/run_tests.sh OK
manual testing OK

Is this related to any issues?

No.
Small change, didn't see a need for an issue.

Have you read the Contributing Guidelines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant