Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/client pooling #128

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

Odonno
Copy link
Contributor

@Odonno Odonno commented Sep 30, 2024

Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.

What does this change do?

SurrealDbClient pooling to avoid the cost of

  1. WS reconnection when using the websocket engine
  2. dropping and creating engines over and over, reducing memory pressure

The embedded modes are not concerned as of now.

What is your testing strategy?

Integrations tests & manual tests

Is this related to any issues?

Fixes #104

Have you read the Contributing Guidelines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Potential performance problem
1 participant