docs-Add missing math constants to documentation pages of numeric data types and math function module
#860
Conversation
… page The documentation page for the numeric data types is missing the following two constants: `math::inf` `math::neg_inf` This commit adds the two missing constants.
…tion page The documentation page for the math` function module is missing the following constants: `math::frac_1_pi` `math::frac_1_sqrt_2` `math::frac_2_pi` `math::frac_2_sqrt_pi` `math::frac_pi_2` `math::frac_pi_3` `math::frac_pi_4` `math::frac_pi_6` `math::frac_pi_8` `math::ln_10` `math::ln_2` `math::log10_2` `math::log10_e` `math::log2_10` `math::log2_e` `math::sqrt_2` This commit adds the two missing constants.
✅ Deploy Preview for surrealdb-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thank you (again!) for the PR! I've been giving some thought to a unified format for consts vs. functions since right now the data types page has the consts in all caps (including the module path) but all lowercase on the functions page. I think what might look best is lowercase for the module paths, and all caps for the final part as long as it's a const. Then the functions page would look like this, making it clear which is a function and which is a const: math::floor And then the numeric types page would match the format and thus end up like this. math::E I'll tag @Ekwuno to see if he likes the idea. |
|
Apologies for the delay on this @matthewjnield I think it's alright as is. I will merge it in now
|
Closes #832.
Commit 1:
docs-Add missing
mathconstants to numeric data types documentation pageThe documentation page for the numeric data types is missing the following two constants:
math::infmath::neg_infThis commit adds the two missing constants.
Commit 2:
docs-Add missing
mathconstants tomathfunction module documentation pageThe documentation page for the math
function module is missing the following constants:math::frac_1_piThis commit adds the missing constants.