Keycodes restored #501
Merged
Keycodes restored #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The onKeyDown handler was reading the wrong part of the data structure, so keypresses didn't navigate patches. Moreover, the handler was over-registered. Finally, once those problems were fixes, make + and - zoom and unzoom the UI. Closes surge-synthesizer#496 Keyboard Hook doesn't work Closes surge-synthesizer#479 +/- for zoom Closes surge-synthesizer#427 Keyboard hook over-registered Due to an error in windows VSTGUI this doesn't fully work on windows, with the keyboard zoom not being supported there. See issue surge-synthesizer#500 for a description of why.
baconpaul
added a commit
to baconpaul/surge
that referenced
this pull request
Jul 10, 2019
Keycodes restored Former-commit-id: a70aaff320b216b0e803cdbb9fdb92a2b3a5bec1 [formerly 589bd29] Former-commit-id: 407bdef1514027ccc68621c78ec9bfa21364ad9b Former-commit-id: a64169503b925322ed3b208a839c969728148d1a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The onKeyDown handler was reading the wrong part of the data
structure, so keypresses didn't navigate patches. Moreover, the
handler was over-registered. Finally, once those problems were
fixes, make + and - zoom and unzoom the UI.
Closes #496 Keyboard Hook doesn't work
Closes #479 +/- for zoom
Closes #427 Keyboard hook over-registered
Due to an error in windows VSTGUI this doesn't fully work on
windows, with the keyboard zoom not being supported there.
See issue #500 for a description of why.