-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Win32 Keyboard Bindings not right in VSTGUI #500
Comments
baconpaul
added a commit
to baconpaul/surge
that referenced
this issue
Feb 4, 2019
The onKeyDown handler was reading the wrong part of the data structure, so keypresses didn't navigate patches. Moreover, the handler was over-registered. Finally, once those problems were fixes, make + and - zoom and unzoom the UI. Closes surge-synthesizer#496 Keyboard Hook doesn't work Closes surge-synthesizer#479 +/- for zoom Closes surge-synthesizer#427 Keyboard hook over-registered Due to an error in windows VSTGUI this doesn't fully work on windows, with the keyboard zoom not being supported there. See issue surge-synthesizer#500 for a description of why.
Merged
Closed
baconpaul
added a commit
to baconpaul/surge
that referenced
this issue
Jul 10, 2019
The onKeyDown handler was reading the wrong part of the data structure, so keypresses didn't navigate patches. Moreover, the handler was over-registered. Finally, once those problems were fixes, make + and - zoom and unzoom the UI. Closes surge-synthesizer#496 Keyboard Hook doesn't work Closes surge-synthesizer#479 +/- for zoom Closes surge-synthesizer#427 Keyboard hook over-registered Due to an error in windows VSTGUI this doesn't fully work on windows, with the keyboard zoom not being supported there. See issue surge-synthesizer#500 for a description of why. Former-commit-id: e0ff13f2588bbfec2ece60f9217e17522756d0fa [formerly 5aef139] Former-commit-id: 9e8d3af55f3c457372964310ba83c19e29da1224 Former-commit-id: f8a51113f2f5e6d738efa060371ab5fbd4cf095a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
VSTGUI seems to not properly propagate pressed regular keys to the gui through the keyboard listener. Inspection on Win10 shows all keys send a character 0 in onKeyDown
This code in vstgui...platform/windows/win32frame.cpp is suspect
Leaving this here so I don't forget. Not sure what to do yet.
The text was updated successfully, but these errors were encountered: