Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add db index to notification.status field #17

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Add db index to notification.status field #17

merged 2 commits into from
Oct 16, 2023

Conversation

DDuarte
Copy link
Contributor

@DDuarte DDuarte commented Oct 16, 2023

No description provided.

@DDuarte DDuarte requested a review from a team as a code owner October 16, 2023 11:12
@DDuarte DDuarte requested review from fopina and cojoeu October 16, 2023 11:12
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (develop@9884faf). Click here to learn what that means.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop      #17   +/-   ##
==========================================
  Coverage           ?   80.83%           
==========================================
  Files              ?       14           
  Lines              ?      527           
  Branches           ?        0           
==========================================
  Hits               ?      426           
  Misses             ?      101           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gsilvapt gsilvapt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might be worth fixing Black and the migration though.

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DDuarte DDuarte merged commit 62e19b3 into develop Oct 16, 2023
7 checks passed
DDuarte added a commit that referenced this pull request Oct 16, 2023
* notification_sender: change logger error to exception (#16)

provide more context on exception handling

Signed-off-by: Duarte Duarte <[email protected]>

* Add db index to notification.status field (#17)

* version bump

---------

Signed-off-by: Duarte Duarte <[email protected]>
@DDuarte DDuarte deleted the status_index branch July 16, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants