Add GHA for hadolint (omec-project#784)

.github/workflows/master.yml

@@ -29,6 +29,23 @@ jobs:
           version: latest
           args: -v --config ./.golangci.yml
 
+  hadolint:
+    name: hadolint
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Dockerfile linter
+        uses: hadolint/[email protected]
+        # For now, ignoring:
+        # DL3007 warning: Pin the version explicitily to a release tag (no latest);
+        # DL3008 warning: Pin versions in apt get install (e.g., apt-get install <package>=<version>); and
+        # DL3018 warning: Pin versions in apk add (e.g., apk add <package>=<version>)
+        with:
+          dockerfile: Dockerfile
+          ignore: DL3007,DL3008,DL3018
+
   check-spelling:
     name: Markdown spellcheck
     runs-on: ubuntu-latest

Dockerfile

@@ -42,9 +42,9 @@ RUN ./install_ntf.sh
 RUN PLUGINS=$(find "$PLUGINS_DIR" -mindepth 1 -maxdepth 1 -type d) && \
     CMD="./build.py bess" && \
     for PLUGIN in $PLUGINS; do \
-        CMD="$CMD --plugin $PLUGIN"; \
+        CMD="$CMD --plugin \"$PLUGIN\""; \
     done && \
-    eval $CMD && \
+    eval "$CMD" && \
     cp bin/bessd /bin && \
     mkdir -p /bin/modules && \
     cp core/modules/*.so /bin/modules && \
@@ -54,6 +54,7 @@ RUN PLUGINS=$(find "$PLUGINS_DIR" -mindepth 1 -maxdepth 1 -type d) && \
 
 # Stage bess: creates the runtime image of BESS
 FROM ubuntu:22.04 AS bess
+WORKDIR /
 COPY requirements.txt .
 RUN apt-get update && apt-get install -y \
     --no-install-recommends \