adds a clarification comment

supertokens · Aug 28, 2024 · 2406b1d · 2406b1d
1 parent c89c3bb
commit 2406b1d
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/lib/build/recipe/emailpassword/api/implementation.js b/lib/build/recipe/emailpassword/api/implementation.js
@@ -699,11 +699,15 @@ function getAPIImplementation() {
                 userContext,
             });
             if (postAuthChecks.status !== "OK") {
-                return authUtils_1.AuthUtils.getErrorStatusResponseWithReason(
+                // It should never actually come here, but we do it cause of consistency.
+                // If it does come here (in case there is a bug), it would make this func throw
+                // anyway, cause there is no SIGN_IN_NOT_ALLOWED in the errorCodeMap.
+                authUtils_1.AuthUtils.getErrorStatusResponseWithReason(
                     postAuthChecks,
                     errorCodeMap,
                     "SIGN_UP_NOT_ALLOWED"
                 );
+                throw new Error("This should never happen");
             }
             return {
                 status: "OK",

diff --git a/lib/ts/recipe/emailpassword/api/implementation.ts b/lib/ts/recipe/emailpassword/api/implementation.ts
@@ -857,7 +857,11 @@ export default function getAPIImplementation(): APIInterface {
             });
 
             if (postAuthChecks.status !== "OK") {
-                return AuthUtils.getErrorStatusResponseWithReason(postAuthChecks, errorCodeMap, "SIGN_UP_NOT_ALLOWED");
+                // It should never actually come here, but we do it cause of consistency.
+                // If it does come here (in case there is a bug), it would make this func throw
+                // anyway, cause there is no SIGN_IN_NOT_ALLOWED in the errorCodeMap.
+                AuthUtils.getErrorStatusResponseWithReason(postAuthChecks, errorCodeMap, "SIGN_UP_NOT_ALLOWED");
+                throw new Error("This should never happen");
             }
 
             return {