Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Introduce MFA recipe #651

Merged
merged 245 commits into from
Mar 13, 2024
Merged

feat: Introduce MFA recipe #651

merged 245 commits into from
Mar 13, 2024

Conversation

KShivendu
Copy link
Contributor

@KShivendu KShivendu commented Apr 27, 2023 •
edited by rishabhpoddar
Loading

Summary of change

Introduce MFA recipe

Related issues

Checklist for important updates

  • Changelog has been updated
    • If there are any db schema changes, mention those changes clearly
  • coreDriverInterfaceSupported.json file has been updated (if needed)
  • pluginInterfaceSupported.json file has been updated (if needed)
  • Changes to the version if needed
    • In build.gradle
  • If added a new paid feature, edit the getPaidFeatureStats function in FeatureFlag.java file
  • Had installed and ran the pre-commit hook
  • If there are new dependencies that have been added in build.gradle, please make sure to add them
    in implementationDependencies.json.
  • Issue this PR against the latest non released version branch.
    • To know which one it is, run find the latest released tag (git tag) in the format vX.Y.Z, and then find the
      latest branch (git branch --all) whose X.Y is greater than the latest released tag.
    • If no such branch exists, then create one from the latest released branch.

Remaining TODOs

Core changes checklist

@rishabhpoddar
adds connection uri and tenant id based resource distributor
ed729ef
@rishabhpoddar
removes unnecessary file
10afc48
@rishabhpoddar
adds a bunch of todos
65012d9
@rishabhpoddar
adds storage layer function and also laod all configs function
737563e
@rishabhpoddar
implements core config merging across tenants
19aade1
@rishabhpoddar
restructures code related to config checking in core
7ed1b8c
@rishabhpoddar
changes storage layer to take json instead of config file path
5723ba1
@rishabhpoddar
small refactor
3ef6397
@rishabhpoddar
adds ability to create new storage instances on the fly
650cffe
@rishabhpoddar
in mem db function impl for user pool ID and config conflict checking
1af722e
@rishabhpoddar
small change
b552ff8
@rishabhpoddar
adds checks for conflicting core configs
67382e5
@rishabhpoddar
adds a few tests for multi tenant config
76d7492
@rishabhpoddar
adds more tests
2ac6616
@rishabhpoddar
more tests
1b0d182
@rishabhpoddar
adds function to get connection pool ID
ba2923b
@rishabhpoddar
adds skeleton for loading storage layers for tenants
40ad561
@rishabhpoddar
fixes compile error
cb6e6d8
@rishabhpoddar
adds code to load multiple storage layers as well
579056b
@rishabhpoddar
deletes info across all tenants during testing
7c37142
@rishabhpoddar
adds one test for storage layer
392a8b0
@rishabhpoddar
fixes a test
1f35011
@rishabhpoddar
fixes bug in setting resource in resource distributor
079ed01
@rishabhpoddar
fixes bugs
c69ca66
@rishabhpoddar
loads signing keys for all tenants
5c2000d
@rishabhpoddar
fixes bug
0fcaf35
@rishabhpoddar
adds new test and modifies the testing kill process to clear database…
980f6c3 
…s across mulitple user pools
@rishabhpoddar
implements more test
2280002
@rishabhpoddar
small change to formatting
3cc9229
@rishabhpoddar
small change to formatting
a0ffc14
sattvikc and others added 9 commits November 15, 2023 11:00
@sattvikc
fix: totp APIs and flaky tests fix (#879)
71f09f1 
* fix: totp APIs and flaky tests fix

* fix: PR comment
@sattvikc
fix: response
fbf0243
@sattvikc
Merge branch '7.0' into feat/mfa
6190d9d
@sattvikc
fix: version update
cbd7de3
@sattvikc
fix: changelog
9a62680
@sattvikc
fix: remove MFA apis
530f869
@sattvikc
fix: remove isValidFirstFactor
755ac1d
@sattvikc
fix: revert account linking api
1c56021
@sattvikc
Mfa changes (#901)
350c973 
* fix: remove tenant config and rename secondary factors

* fix: version prefix in logging

* fix: remove totp enabled

* fix: firstFactors and requiredSecondaryFactors validation

* fix: remove totpEnabled

* fix: more validation

* fix: version in core logs

* fix: error message
@sattvikc sattvikc mentioned this pull request Dec 25, 2023
Merged
13 tasks
rishabhpoddar
rishabhpoddar suggested changes Dec 25, 2023
View reviewed changes
CHANGELOG.md

### Migration

- TODO - copy once postgres / mysql changelog is done
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO

src/main/java/io/supertokens/multitenancy/Multitenancy.java Show resolved Hide resolved
@sattvikc sattvikc mentioned this pull request Jan 22, 2024
Merged
13 tasks
sattvikc and others added 14 commits January 27, 2024 10:56
@sattvikc
fix: createNewRecipeUser input in consume code API (#910)
b09ea39 
* fix: createNewRecipeUser flag in consume code API

* fix: more tests

* fix: update test

* fix: pr comments
@porcellus
feat: make refresh sync signing key setting (#909)
9ef8d5f 
* feat: make refresh update the signing key type of sessions

* feat: make the refresh and create session apis consistent

* test: remove test log

* chore: update changelog

* test: update tests to use new param
@sattvikc
fix: totp import api (#915)
f884b13 
* fix: totp import api

* fix: refactor
@sattvikc
fix: Fake email verified for emailpassword sign up (#913)
7164a2b 
* fix: mark fake email as verified in emailpassword sign up

* fix: add tests

* fix: pr comments

* fix: clean
@sattvikc @rishabhpoddar @anku255
Merge 7.0 (#940)
e1fcd0c 
* fix: adds test for user pagination from old version (#893)

* adding dev-v7.0.15 tag to this commit to ensure building

* fix: core config validation (#894)

* fix: core config validation

* fix: core config validation

* fix: PR comments

* fix: PR comments

* fix: test

* fix: startup test

* fix: using ConfigMapper

* fix: test

* fix: config mapper

* fix: core config

* adding dev-v7.0.16 tag to this commit to ensure building

* fix: null handling in config mapper (#897)

* fix: core config validation

* fix: core config validation

* fix: PR comments

* fix: PR comments

* fix: test

* fix: startup test

* fix: using ConfigMapper

* fix: test

* fix: config mapper

* fix: core config

* fix: null handling

* fix: test defaults

* adding dev-v7.0.16 tag to this commit to ensure building

* Add t4-app in release checklist (#899)

* Update README.md

* Add Dockerfile for ubuntu 22.04 (#904)

* fix: error logs should be printed to StdErr (#918)

* fix: Load only cud (#917)

* fix: update config and validateAndNormalize

* fix: impl

* fix: PR comments

* fix: cleanup

* fix: cleanup

* fix: pr comments

* fix: pr comments

* fix: tests

* fix: changelog

* fix: 400 error

* fix: cuds from db

* fix: connection pool issue (#919)

* adding dev-v7.0.17 tag to this commit to ensure building

* fix: Test fix (#921)

* fix: test

* fix: tests

* adding dev-v7.0.17 tag to this commit to ensure building

* fix: CICD tests (#925)

* fix: tests

* fix: adding retry

* fix: kill

* fix: typo

* fix: cicd

* fix: cicd

* adding dev-v7.0.17 tag to this commit to ensure building

* fix: Vulnerability fix (#928)

* fix: updated dependencies

* fix: updated dependencies

* chore: version and changelog

* fix: update impl deps

* fix: telemetry data

* fix: changelog

* fix: cleanup

* fix: active user storage

* fix: active users storage test

* fix: changelog

* fix: versions

* adding dev-v7.0.18 tag to this commit to ensure building

* fix: Cicd tests fix (#932)

* fix: CICD fix

* fix: test fix

* fix: test for mongo

* adding dev-v7.0.18 tag to this commit to ensure building

* fix: dependencies (#933)

* fix: dependency fix

* fix: dep fix

* adding dev-v7.0.18 tag to this commit to ensure building

* fix: dependencies (#934)

* adding dev-v7.0.18 tag to this commit to ensure building

* fix: 31 days of mau (#936)

* fix: MAU computation (#937)

* fix: mau

* fix: typo

* adding dev-v7.0.18 tag to this commit to ensure building

* fix: mau related tests (#938)

* adding dev-v7.0.18 tag to this commit to ensure building

* fix: Tests (#939)

* fix: mau related tests

* fix: test

* adding dev-v7.0.18 tag to this commit to ensure building

---------

Co-authored-by: rishabhpoddar <[email protected]>
Co-authored-by: Ankit Tiwari <[email protected]>
@sattvikc @rishabhpoddar @anku255
merge latest (#947)
4a3a63d 
* fix: adds test for user pagination from old version (#893)

* adding dev-v7.0.15 tag to this commit to ensure building

* fix: core config validation (#894)

* fix: core config validation

* fix: core config validation

* fix: PR comments

* fix: PR comments

* fix: test

* fix: startup test

* fix: using ConfigMapper

* fix: test

* fix: config mapper

* fix: core config

* adding dev-v7.0.16 tag to this commit to ensure building

* fix: null handling in config mapper (#897)

* fix: core config validation

* fix: core config validation

* fix: PR comments

* fix: PR comments

* fix: test

* fix: startup test

* fix: using ConfigMapper

* fix: test

* fix: config mapper

* fix: core config

* fix: null handling

* fix: test defaults

* adding dev-v7.0.16 tag to this commit to ensure building

* Add t4-app in release checklist (#899)

* Update README.md

* Add Dockerfile for ubuntu 22.04 (#904)

* fix: error logs should be printed to StdErr (#918)

* fix: Load only cud (#917)

* fix: update config and validateAndNormalize

* fix: impl

* fix: PR comments

* fix: cleanup

* fix: cleanup

* fix: pr comments

* fix: pr comments

* fix: tests

* fix: changelog

* fix: 400 error

* fix: cuds from db

* fix: connection pool issue (#919)

* adding dev-v7.0.17 tag to this commit to ensure building

* fix: Test fix (#921)

* fix: test

* fix: tests

* adding dev-v7.0.17 tag to this commit to ensure building

* fix: CICD tests (#925)

* fix: tests

* fix: adding retry

* fix: kill

* fix: typo

* fix: cicd

* fix: cicd

* adding dev-v7.0.17 tag to this commit to ensure building

* fix: Vulnerability fix (#928)

* fix: updated dependencies

* fix: updated dependencies

* chore: version and changelog

* fix: update impl deps

* fix: telemetry data

* fix: changelog

* fix: cleanup

* fix: active user storage

* fix: active users storage test

* fix: changelog

* fix: versions

* adding dev-v7.0.18 tag to this commit to ensure building

* fix: Cicd tests fix (#932)

* fix: CICD fix

* fix: test fix

* fix: test for mongo

* adding dev-v7.0.18 tag to this commit to ensure building

* fix: dependencies (#933)

* fix: dependency fix

* fix: dep fix

* adding dev-v7.0.18 tag to this commit to ensure building

* fix: dependencies (#934)

* adding dev-v7.0.18 tag to this commit to ensure building

* fix: 31 days of mau (#936)

* fix: MAU computation (#937)

* fix: mau

* fix: typo

* adding dev-v7.0.18 tag to this commit to ensure building

* fix: mau related tests (#938)

* adding dev-v7.0.18 tag to this commit to ensure building

* fix: Tests (#939)

* fix: mau related tests

* fix: test

* adding dev-v7.0.18 tag to this commit to ensure building

* fix: fixes storage handling for non-auth recipes (#942)

* fix: non auth recipe stuff

* fix: user roles

* fix: half done

* fix: thirdparty changes

* fix: passwordless changes

* fix: active users

* fix: session changes

* fix: user metadata

* fix: user roles

* fix: totp

* fix: email verification

* fix: multitenancy and other minor fixes

* fix: compile errors

* fix: bugs and tests

* fix: bugs and tests

* fix: func rename

* fix: PR comments

* fix: pr comments

* fix: pr comments

* fix: pr comments

* fix: user role multitenant tests

* fix: email verification tests

* fix: user role deletion

* fix: user roles

* fix: user roles

* fix: get tenant identifier refactor

* fix: pr comments

* fix: query

* fix: tests version and changelog

* Update CHANGELOG.md

Co-authored-by: Rishabh Poddar <[email protected]>

* fix: pr comments

---------

Co-authored-by: Rishabh Poddar <[email protected]>

* adding dev-v8.0.0 tag to this commit to ensure building

* fix: plugin interface version (#945)

* adding dev-v8.0.0 tag to this commit to ensure building

* fix: cicd tests (#946)

* fix: cicd tests

* fix: cicd tests

* fix: cicd tests

* fix: cicd tests

* fix: cicd tests

* adding dev-v8.0.0 tag to this commit to ensure building

---------

Co-authored-by: rishabhpoddar <[email protected]>
Co-authored-by: Ankit Tiwari <[email protected]>
@sattvikc
fix: add check code API and update delete code API (#948)
3f46b5d 
* fix: verify code API

* pr comments

* fix: cleanup

* fix: PR comments

* fix: pr comment
@sattvikc
Merge branch '8.0' into merge-8
697eafc
@sattvikc
fix: revert formatting
b44fbe7
@sattvikc
fix: revert formatting
a6992c8
@sattvikc
Merge pull request #955 from supertokens/merge-8
d44fdba 
Merge 8
@porcellus @sattvikc
feat: merge last active times when linking users (#954)
c4ba0b1 
* feat: merge last active times when linking users

* fix: pr comments

* fix: cleanup

* fix: pr comments

* fix: cleanup

---------

Co-authored-by: Sattvik Chakravarthy <[email protected]>
@sattvikc
Remaining changes (#956)
941bc67 
* fix: enforce public tenant

* fix: enforce public tenant >= 5.0

* fix: pass appId to getUserIdMappingForSuperTokensIds

* fix: create session with useridmapping

* fix: consumed device

* fix: list and remove tenant api enforcement

* fix: firstFactors and secondFactors in multitenancy stats

* fix: tests

* fix: tests

* fix: versions

* fix: PR coments

* fix: pr comments

* fix: null handling
@sattvikc
fix: fixme
60e5b69
@sattvikc sattvikc changed the base branch from 7.0 to 8.0 March 13, 2024 15:02
@rishabhpoddar rishabhpoddar changed the base branch from 8.0 to 9.0 March 13, 2024 15:10
@rishabhpoddar rishabhpoddar merged commit accf6f1 into 9.0 Mar 13, 2024
4 of 7 checks passed
@rishabhpoddar rishabhpoddar deleted the feat/mfa branch March 13, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabhpoddar rishabhpoddar rishabhpoddar requested changes

Assignees

@sattvikc sattvikc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KShivendu @rishabhpoddar @sattvikc @porcellus