Rdo 6 1 liner sdk examples #243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o get the examples shorter"
John-Memphis
requested review from
idanasulin2706,
shay23b and
daniel-davidd
as code owners
|
Please change the examples in the examples directory as well, in all sdks |
…isdev/memphis.py into RDO-6-1-liner-sdk-examples
|
Quick start should be the shortest way to send/receive messages. |
shay23b
previously requested changes
Jan 4, 2024
|
3.8 fails because of using new type hinting syntax that became available in 3.9. Should I go back to syntax that is available in 3.8? |
shay23b
requested changes
Jan 15, 2024
| host = "<memphis-host>", | ||
| username = "<memphis-username>", | ||
| password = "<memphis-password>", | ||
| account_id = <mmephis-account-id> # For cloud users, at the top of the overview page |
There was a problem hiding this comment.
@shay23b Same issue with the comment in the C# branch, where this fails linting when I don't comment out that.
Is that okay? I don't know how to change the rules so it allows that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.