avro validation #189
Merged
avro validation #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idanasulin2706
approved these changes
Jul 27, 2023
|
Looks great @Big-Vi, will be merged once we will merge the broker PR |
idanasulin2706
approved these changes
Jul 31, 2023
There was a problem hiding this comment.
@Big-Vi big thank you for this amazing contribution, approved.
Before merging just please resolve the lint issues
Resolved. Thanks. |
rnowling-memphis
approved these changes
Jul 31, 2023
|
@Big-Vi Fantastic work! I merged your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to superstreamlabs/memphis#1107
I've used
https://github.com/fastavro/fastavroinstead ofhttps://github.com/apache/avrobecause of it's performance.