Add error handling for closed connection in sdk update listener

superstreamlabs · Jan 26, 2024 · 7aedd85 · 7aedd85
1 parent 18105cc
commit 7aedd85
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/src/Memphis.Client.IntegrationTests/FullFlowTests.cs b/src/Memphis.Client.IntegrationTests/FullFlowTests.cs
@@ -1,4 +1,5 @@
 using System.Collections.Specialized;
+using System.Diagnostics;
 using System.Text;
 using Memphis.Client.Consumer;
 using Memphis.Client.Producer;
@@ -201,9 +202,11 @@ public static async Task<int> CountMessagesConsumedByGroup(MemphisConsumer consu
  args.MessageList.ForEach(msg => msg.Ack());
  };
 
- _ = consumer1.ConsumeAsync(new ConsumeOptions { PartitionKey = partitionKey });
- _ = consumer2.ConsumeAsync(new ConsumeOptions { PartitionKey = partitionKey });
- await Task.Delay(TimeSpan.FromSeconds(10));
+ await Task.WhenAny(
+ consumer1.ConsumeAsync(new ConsumeOptions { PartitionKey = partitionKey }),
+ consumer2.ConsumeAsync(new ConsumeOptions { PartitionKey = partitionKey }),
+ Task.Delay(TimeSpan.FromSeconds(30)));
+
  return count;
  }
 }
diff --git a/src/Memphis.Client/MemphisClient.cs b/src/Memphis.Client/MemphisClient.cs
@@ -1025,6 +1025,10 @@ void SyncSdkClientUpdate()
  }
  }
  }
+ catch when (!IsConnected())
+ {
+ // Connection is closed 
+ }
  catch (System.Exception exception)
  {
  throw new MemphisException(exception.Message, exception);