Updated max reconnect to retry forever (#220)

* Updated maxReconnect to retry forever * Updated README * Updated unlimited reconnection guide
superstreamlabs · Dec 7, 2023 · 9f161c7 · 9f161c7
1 parent e527d57
commit 9f161c7
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/README.md b/README.md
@@ -70,7 +70,7 @@ await memphis.connect({
  connectionToken: "<broker-token>", // you will get it on application type user creation
  password: "<string>", // depends on how Memphis deployed - default is connection token-based authentication
  reconnect: true, // defaults to true
- maxReconnect: 10, // defaults to 10
+ maxReconnect: 10, // The default value is -1 which means reconnect indefinitely
  reconnectIntervalMs: 1500, // defaults to 1500
  timeoutMs: 15000, // defaults to 15000
  // for TLS connection:

diff --git a/lib/memphis.js b/lib/memphis.js
@@ -53,7 +53,7 @@ class Memphis {
  this.accountId = 1;
  this.connectionToken = '';
  this.reconnect = true;
- this.maxReconnect = 10;
+ this.maxReconnect = -1;
  this.reconnectIntervalMs = 1500;
  this.timeoutMs = 15000;
  this.brokerConnection = null;
@@ -79,7 +79,7 @@ class Memphis {
  this.stationPartitions = new Map();
  this.seed = 31;
  }
- connect({ host, port = 6666, username, accountId = 1, connectionToken = '', password = '', reconnect = true, maxReconnect = 10, reconnectIntervalMs = 1500, timeoutMs = 2000, keyFile = '', certFile = '', caFile = '', suppressLogs = false }) {
+ connect({ host, port = 6666, username, accountId = 1, connectionToken = '', password = '', reconnect = true, maxReconnect = -1, reconnectIntervalMs = 1500, timeoutMs = 2000, keyFile = '', certFile = '', caFile = '', suppressLogs = false }) {
  return new Promise(async (resolve, reject) => {
  this.host = this._normalizeHost(host);
  this.port = port;

diff --git a/lib/tsconfig.build.tsbuildinfo b/lib/tsconfig.build.tsbuildinfo
diff --git a/src/memphis.ts b/src/memphis.ts
@@ -114,7 +114,7 @@ class Memphis {
  this.accountId = 1;
  this.connectionToken = '';
  this.reconnect = true;
- this.maxReconnect = 10;
+ this.maxReconnect = -1;
  this.reconnectIntervalMs = 1500;
  this.timeoutMs = 15000;
  this.brokerConnection = null;
@@ -150,7 +150,7 @@ class Memphis {
  * @param {String} connectionToken - connection token.
  * @param {String} password - depends on how Memphis deployed - default is connection token-based authentication
  * @param {Boolean} reconnect - whether to do reconnect while connection is lost.
- * @param {Number} maxReconnect - The reconnect attempts.
+ * @param {Number} maxReconnect - is the maximum number of reconnection attempts. The default value is -1 which means reconnect indefinitely.
  * @param {Number} reconnectIntervalMs - Interval in miliseconds between reconnect attempts.
  * @param {Number} timeoutMs - connection timeout in miliseconds.
  * @param {string} keyFile - path to tls key file.
@@ -167,7 +167,7 @@ class Memphis {
  connectionToken = '',
  password = '',
  reconnect = true,
- maxReconnect = 10,
+ maxReconnect = -1,
  reconnectIntervalMs = 1500,
  timeoutMs = 2000,
  keyFile = '',