Merge pull request #217 from memphisdev/bugfix/RND-31-when-user-creat…

…e-station-from-sdk-the-default-retention-is-7-days-rather-than-1-hour change the retentionValue to 1 hour
superstreamlabs · Nov 28, 2023 · 06b4704 · 06b4704
2 parents f4bb37f + 95b1a40
commit 06b4704
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -214,7 +214,7 @@ const station = await memphis.station({
  name: '<station-name>',
  schemaName: '<schema-name>',
  retentionType: memphis.retentionTypes.MAX_MESSAGE_AGE_SECONDS, // defaults to memphis.retentionTypes.MAX_MESSAGE_AGE_SECONDS
- retentionValue: 604800, // defaults to 604800
+ retentionValue: 3600, // defaults to 3600
  storageType: memphis.storageTypes.DISK, // defaults to memphis.storageTypes.DISK
  replicas: 1, // defaults to 1
  idempotencyWindowMs: 0, // defaults to 120000

diff --git a/lib/memphis.js b/lib/memphis.js
@@ -482,7 +482,7 @@ class Memphis {
  throw (0, utils_1.MemphisError)(ex);
  }
  }
- async station({ name, retentionType = retentionTypes.MAX_MESSAGE_AGE_SECONDS, retentionValue = 604800, storageType = storageTypes.DISK, replicas = 1, idempotencyWindowMs = 120000, schemaName = '', sendPoisonMsgToDls = true, sendSchemaFailedMsgToDls = true, tieredStorageEnabled = false, partitionsNumber = 1, dlsStation = '', timeoutRetry = 5 }) {
+ async station({ name, retentionType = retentionTypes.MAX_MESSAGE_AGE_SECONDS, retentionValue = 3600, storageType = storageTypes.DISK, replicas = 1, idempotencyWindowMs = 120000, schemaName = '', sendPoisonMsgToDls = true, sendSchemaFailedMsgToDls = true, tieredStorageEnabled = false, partitionsNumber = 1, dlsStation = '', timeoutRetry = 5 }) {
  var _a;
  try {
  if (partitionsNumber < 1) {

diff --git a/lib/tsconfig.build.tsbuildinfo b/lib/tsconfig.build.tsbuildinfo
diff --git a/src/memphis.ts b/src/memphis.ts
@@ -611,7 +611,7 @@ class Memphis {
  async station({
  name,
  retentionType = retentionTypes.MAX_MESSAGE_AGE_SECONDS,
- retentionValue = 604800,
+ retentionValue = 3600,
  storageType = storageTypes.DISK,
  replicas = 1,
  idempotencyWindowMs = 120000,