Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add Helm labels and annotations to cilium GatewayClass #11

Merged
merged 1 commit into from
Oct 9, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions work/manifests/gateway-api/manifests/gateway-class.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
# The `cilium` GatewayClass should technically be deployed automatically,
# however, that is not reliable in practice. We can specify the resource here,
# but the Helm labels and annotations must also be present, otherwise Cilium
# won't deploy without complaining.
apiVersion: gateway.networking.k8s.io/v1
kind: GatewayClass
metadata:
name: cilium
labels:
app.kubernetes.io/managed-by: Helm
annotations:
meta.helm.sh/release-name: cilium
meta.helm.sh/release-namespace: kube-system
spec:
controllerName: io.cilium/gateway-controller