Skip to content

Commit

Permalink
- Fixed: Update button was disabled when NuGet determined the latest …
Browse files Browse the repository at this point in the history
…version was installed
  • Loading branch information
alexis- committed Apr 29, 2020
1 parent 55d7de2 commit 2cb44f3
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion ChangeLogs
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT UNLESS YOU KNOW WHAT YOU ARE DOING.
# CHANGE LOG

[Next version (ffd3f6fed045f481f2a67a10ae83ea9599be3052)]
[2.0.5-alpha.14]
- Updated: Packages
- Fixed: Installer's Stub executable didn't handle semver 2.0 correctyl
- Fixed: Installer didn't recognize semantic version correctly
Expand Down
3 changes: 3 additions & 0 deletions src/Core/SuperMemoAssistant/Build/Packaging.targets
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
<Project>
<Target Name="WriteChangeLog" BeforeTargets="Build" DependsOnTargets="CreateChangeLogs">
</Target>

<Target Name="UpdateNuSpec" BeforeTargets="GenerateNuspec" DependsOnTargets="PreparePackage">
<PropertyGroup>
<NuspecProperties>version=$(PackageVersion);repositoryType=$(RepositoryType);repositoryUrl=$(RepositoryUrl);commitId=$(GitCommitId);outputPath=$(OutputPath)</NuspecProperties>
Expand Down
2 changes: 0 additions & 2 deletions src/Core/SuperMemoAssistant/SuperMemoAssistant.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,4 @@
</ItemGroup>
<Import Project="Build\*.props" />
<Import Project="Build\*.targets" />
<Target Name="WriteChangeLog" AfterTargets="Build" DependsOnTargets="CreateChangeLogs">
</Target>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ private async Task PluginUpdateAsync(LocalPluginPackage<PluginMetadata> plugin)
/// <returns></returns>
private bool CanPluginUpdate(LocalPluginPackage<PluginMetadata> pluginPackage)
{
return pluginPackage?.Metadata.IsDevelopment == false && pluginPackage.HasPendingUpdates;
return pluginPackage?.Metadata.IsDevelopment == false && pluginPackage.SelectedVersion != pluginPackage.Identity.Version;
}

/// <summary>Toggle the enabled status of plugin <paramref name="pluginInstance" /></summary>
Expand Down

0 comments on commit 2cb44f3

Please sign in to comment.