feat: make query adapter minimally invasive #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the optimal query adapter could overfit on the provided (q, p, n) triplets. The query adapter overcorrected in that it inverted incorrectly ranked (p, n) pairs, but also affected correctly ranked items.
After this PR, the query adapter is weighted so that it applies only the smallest correction necessary to invert incorrectly ranked (p, n) pairs, without attempting to maximally increase p and decrease n at the expense of other queries.
Additionally, this PR makes the query adapter configurable in the
RAGLiteConfig.