Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore VS Code logo #263

Merged
merged 1 commit into from
Dec 22, 2024
Merged

fix: restore VS Code logo #263

merged 1 commit into from
Dec 22, 2024

Conversation

lsorber
Copy link
Member

@lsorber lsorber commented Dec 20, 2024

For context:

  1. Shields.io badges depend on Simple Icons [1] to serve logos like that of VS Code or GitHub.
  2. Simple Icons decided to remove all Microsoft logos in accordance with their terms of use [2].
  3. As a result, our Open in Dev Containers badge no longer has a logo, while the Open in GitHub Codespaces badge does.
  4. That said, VS Code specifically does actually allow using its logo in documentation [3].

Changes:

  1. We use Shields.io's inline base64-encoded svg logo feature [1] to restore the missing VS Code logo.

[1] https://shields.io/docs/logos
[2] simple-icons/simple-icons#10019
[3] https://code.visualstudio.com/brand#brand-icon-usage

@lsorber lsorber requested a review from sinopeus December 20, 2024 16:00
@lsorber lsorber self-assigned this Dec 20, 2024
@lsorber lsorber merged commit 0b4edb2 into main Dec 22, 2024
8 checks passed
@lsorber lsorber deleted the ls-vscode-badge branch December 22, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant