Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for Dev Containers with PyCharm #261

Merged
merged 1 commit into from
Jan 20, 2025
Merged

feat: add support for Dev Containers with PyCharm #261

merged 1 commit into from
Jan 20, 2025

Conversation

lsorber
Copy link
Member

@lsorber lsorber commented Dec 20, 2024 •
edited
Loading

Changes:

  1. Improve the PyCharm Dev Container experience.
  2. Include nodejs in the image, which is also needed for the GitHub Copilot PyCharm plugin.
  3. Remove the PyCharm Docker Compose interpreter dev environment (which is now replaced by Dev Containers).

Related: #256.

@lsorber lsorber requested a review from undo76 December 20, 2024 13:50
@lsorber lsorber self-assigned this Dec 20, 2024
@lsorber lsorber mentioned this pull request Dec 20, 2024
Open
@lsorber lsorber force-pushed the ls-pycharm-devc branch 2 times, most recently from 4104492 to c42fc45 Compare December 20, 2024 14:05
sinopeus
sinopeus approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@sinopeus sinopeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this and while PyCharm's Dev Containers implementation is itself somewhat janky and certainly not as seamless as VS Code's, this integration works. LGTM!

@lsorber lsorber merged commit c7ee628 into main Jan 20, 2025
4 checks passed
@lsorber lsorber deleted the ls-pycharm-devc branch January 20, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sinopeus sinopeus sinopeus approved these changes

@undo76 undo76 Awaiting requested review from undo76

Assignees

@lsorber lsorber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsorber @sinopeus