Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove zIndex property #2124

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/apps/Planning/PlanningListSubNav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ class PlanningListSubNavComponent extends React.Component<IProps, IState> {

return (
<div ref={this.onContainerMounted}>
<SubNav className="subnav-event-planning" zIndex={1}>
<SubNav className="subnav-event-planning">
<ButtonGroup align="inline">
<FilterSubnavDropdown viewSize={this.state.viewSize} />

Expand Down
4 changes: 2 additions & 2 deletions client/apps/Planning/PlanningSubNav.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export class PlanningSubNavComponent extends React.PureComponent<IProps> {
{this.props.withArchiveItem !== true ? null : (
<ArchiveItem item={this.props.archiveItem} />
)}
<SubNav zIndex={3}>
<SubNav>
<MultiSelectActions />
<SearchBox
label={gettext('Search planning')}
Expand All @@ -110,7 +110,7 @@ export class PlanningSubNavComponent extends React.PureComponent<IProps> {
privileges={this.props.privileges}
/>
</SubNav>
<SubNav zIndex={2}>
<SubNav>
<ButtonGroup align="inline">
<NavButton
icon="filter-large"
Expand Down
2 changes: 1 addition & 1 deletion client/components/Assignments/FiltersBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const FiltersBar = ({
const {gettext} = superdeskApi.localization;

return (
<SubNav zIndex={2}>
<SubNav>
<StretchBar>
{!showDeskSelection ? (
<Fragment>
Expand Down
2 changes: 1 addition & 1 deletion client/components/Assignments/SubNavBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export class SubNavBar extends React.PureComponent<IProps> {
const {gettext} = superdeskApi.localization;

return (
<SubNav zIndex={3}>
<SubNav>
{assignmentListSingleGroupView && (
<ButtonGroup align="start">
<Tooltip
Expand Down
1 change: 0 additions & 1 deletion client/components/Coverages/CoverageIcons.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ export class CoverageIcons extends React.PureComponent<IProps> {
return (
<WithPopover
placement="auto-end"
zIndex={1051}
component={() => (
<div className="coverages-popup">
<Spacer v gap="16">
Expand Down
2 changes: 1 addition & 1 deletion client/components/Events/EventItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class EventItemComponent extends React.Component<IProps, IState> {

return (
<div>
<Menu zIndex={1050} items={itemActions}>
<Menu items={itemActions}>
{
(toggle) => (
<div
Expand Down
2 changes: 1 addition & 1 deletion client/components/Planning/PlanningItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ class PlanningItemComponent extends React.Component<IProps, IState> {

return (
<div>
<Menu zIndex={1050} items={itemActions}>
<Menu items={itemActions}>
{
(toggle) => (
<div
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,6 @@ export default class PlanningTemplatesModal extends React.Component<IProps, ISta
>
<Dropdown
maxHeight={300}
append
zIndex={2001}
items={calendarDropdownItems.sort((cal1, cal2) => cal1.label.localeCompare(cal2.label))}
>
{dropdownLabel}
Expand Down
1 change: 0 additions & 1 deletion client/components/fields/editor/CustomVocabularies.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ class CustomVocabulariesComponent extends React.PureComponent<IProps> {
);
}}
tabindex={0}
zIndex={1051}
/>
</Row>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -162,8 +162,6 @@ export class EventsRelatedArticlesModal extends React.Component<IProps, IState>
>
<Dropdown
maxHeight={300}
append
zIndex={2001}
items={[
{
type: 'group',
Expand Down
1 change: 0 additions & 1 deletion client/components/fields/editor/base/numberSelect.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ export class EditorFieldNumberSelect extends React.PureComponent<IProps> {
value={values}
onChange={this.onChangeMultiple}
allowMultiple={true}
zIndex={1051}
/>
);
}
Expand Down
1 change: 0 additions & 1 deletion client/components/fields/editor/base/treeSelect.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ export class EditorFieldTreeSelect<T> extends React.PureComponent<IEditorFieldTr
label={this.props.label}
tabindex={0}
info={this.props.info}
zIndex={1051}
sortable={this.props.sortable}
/>
</Row>
Expand Down
7 changes: 0 additions & 7 deletions client/styles/index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,6 @@
justify-content: flex-end;
}

// Fix second subnav's z-index in Planning page
#sd-planning-react-container {
.subnav + .subnav {
z-index: 1002 !important;
}
}

// Fix react-bootstrap OverlayTrigger's Tooltip inside Modals
.tooltip {
z-index: 10000 !important;
Expand Down
Loading
Loading