Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Planning items created via an event are not always scheduled, but are being kept in draft mode [SDBELGA-879] #2113

Merged
merged 3 commits into from
Oct 16, 2024
Merged

Fix: Planning items created via an event are not always scheduled, but are being kept in draft mode [SDBELGA-879] #2113

merged 3 commits into from
Oct 16, 2024

Conversation

devketanpro
Copy link
Member

@devketanpro devketanpro commented Oct 14, 2024 •
edited
Loading

when we remove the required field from the editor, in the schema its still marked as required, so when we validate the related_item, it gives us validation error as it is required

Front-end checklist

  • This pull request is adding missing TypeScript types to modified code segments where it's easy to do so with confidence
  • This pull request is using TypeScript interfaces instead of prop-types and updates usages where it's quick to do so
  • This pull request is using memo or PureComponent to define new React components (and updates existing usages in modified code segments)
  • This pull request is replacing lodash.get with optional chaining and nullish coalescing for modified code segments
  • This pull request is not importing anything from client-core directly (use superdeskApi)
  • This pull request is importing UI components from superdesk-ui-framework and superdeskApi when possible instead of using ones defined in this repository.
  • This pull request is not using planningApi where it is possible to use superdeskApi
  • This pull request is not adding redux based modals
  • In this pull request, properties of redux state are not being passed as props to components; instead, we connect it to the component that needs them. Except components where using a react key is required - do not connect those due to performance reasons.
  • This pull request is not adding redux actions that do not modify state (e.g. only calling angular services; those should be moved to planningApi)

@MarkLark86
Copy link
Collaborator

Is there a ticket associated with this change, or did you notice this one yourself?
A ticket would be good so that QA can verify the fix as well

@devketanpro
Copy link
Member Author

devketanpro commented Oct 14, 2024 •
edited by jira bot
Loading

Gideon and I discovered this issue while testing ticket SDBELGA-879. For your reference, you can check the thread here: Slack Thread.

@devketanpro devketanpro changed the title fix: when field is disabled in the editor, mark it as not required to avoid backend validation issues. fix: when field is disabled in the editor, mark it as not required to avoid backend validation issues [SDBELGA-879] Oct 14, 2024
@devketanpro devketanpro changed the title fix: when field is disabled in the editor, mark it as not required to avoid backend validation issues [SDBELGA-879] Fix: Planning items created via an event are not always scheduled, but are being kept in draft mode [SDBELGA-879] Oct 14, 2024
@devketanpro devketanpro merged commit 575f205 into superdesk:develop Oct 16, 2024
12 checks passed
@devketanpro devketanpro deleted the fix_validation_issue branch October 16, 2024 08:19
@devketanpro devketanpro added this to the 2.8.1 milestone Oct 16, 2024
devketanpro added a commit that referenced this pull request Oct 16, 2024
@devketanpro
Fix: Planning items created via an event are not always scheduled, bu…
0cd2a63 
…t are being kept in draft mode [SDBELGA-879] (#2113)

* fix backend validation issue on non enabled fields

* remove frontend chnages and implement backend

* update behave tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkLark86 MarkLark86 MarkLark86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.8.1
Development

Successfully merging this pull request may close these issues.
2 participants
@devketanpro @MarkLark86