-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDESK-7372] New Auth mechanism #2729
Conversation
This PR is missing the docs and tests. The tests are covered by the Newshub PR that I will create, as it uses this new auth mechanism throughout it's tests. I will add docs and tests for this core feature in a separate PR, just wanting to get this one in and reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I just left a couple of minor comments.
superdesk/core/web/endpoints.py
Outdated
async def return_404() -> Response: | ||
return Response("", 404) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need async
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added support for non-async endpoint functions now.
Purpose
Implement a new Authentication and Authorization mechanism, for use with async resources and endpoints
What has changed
Resolves: SDESK-7372