Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planning integration adjustments #4686

Open
wants to merge 21 commits into
base: develop
Choose a base branch
from

Conversation

thecalcc
Copy link
Contributor

@thecalcc thecalcc commented Nov 13, 2024

STT-108

TODO:

  • Don't show 3 dots menu if no actions
  • Don't show toolbars if no actions are there
  • Fix print preview & secondary toolbar
  • Don't show header collapse button if no fields are in the header
  • Shortcuts for print preview, theme switch, theme config work

@thecalcc
Copy link
Contributor Author

Note - the SideNav component has only className available as a prop through which you can modify styles. I've went ahead and put a px-2 class coming from UI framework

@thecalcc
Copy link
Contributor Author

Branch based on thecalcc:fix-profile-dropdown

@thecalcc
Copy link
Contributor Author

thecalcc commented Nov 13, 2024

Header without any fields:

image image

Secondary toolbar, that has no actions (doesn't render):
image


Primary toolbar, no actions (only 3 dots menu):
image


Primary toolbar, no actions (no 3 dots menu):
image


Authoring, no actions on both toolbars (only header actions):
image


Authoring, no actions on both toolbars (no header actions):
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants